fix(bulk-editor): load the HelpScout support beacon on the bulk editor page#23453
Merged
Conversation
Coverage Report for CI Build 70714Coverage increased (+0.02%) to 55.168%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions59 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing HelpScout support beacon on the Bulk editor admin page by adding the Bulk editor page slug to the beacon page allowlist, ensuring the beacon is enqueued there like other Yoast admin pages.
Changes:
- Add the Bulk editor page (
wpseo_page_bulk_edit) to the HelpScout beacon allowlist inHelpScout_Beacon. - Add a unit test asserting the Bulk editor page is included in the beacon page map.
- Adjust Bulk editor app layout spacing (adds a bottom margin on the main content wrapper).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/integrations/admin/helpscout-beacon.php |
Adds Bulk_Editor_Integration::PAGE to the beacon allowlist so the beacon loads on the Bulk editor page. |
tests/Unit/Integrations/Admin/HelpScout_Beacon_Test.php |
New unit test to guard the allowlist entry for the Bulk editor page. |
packages/js/src/bulk-editor/app.js |
Adds bottom spacing to the Bulk editor content container (UI/layout tweak). |
Contributor
|
CR & Acceptance: ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes plugins-automated-testing#3074: the HelpScout support beacon (the "Chat with us" widget shown on every other Yoast SEO admin page) was not loaded on the bulk editor page. The beacon only renders on an allowlist of admin pages, and the bulk editor page was missing from that list.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Bulk_Editor_Integration::PAGE(wpseo_page_bulk_edit) toHelpScout_Beacon::$base_pages, sois_beacon_page()enqueues the beacon on the bulk editor like every other Yoast admin page. No constructor/DI change.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
HelpScout_Beacon) — one page added; other pages unaffected.Other environments
Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes Yoast/plugins-automated-testing#3074