-
Notifications
You must be signed in to change notification settings - Fork 969
Remove the AI Brand Insights modals from the Yoast SEO installation #23439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
06a9d34
Remove AI Brand Insights Post Launch modal and associated tests; upda…
JorPV 402d31c
Remove AI Brand Insights free-trial modal after installation
JorPV 9273e21
Remove the unused AI Brand Insights modal components
JorPV b8b2071
Remove the unused AI Brand Insights pre-launch modal component
JorPV 3ea8a72
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into 23431-rem…
JorPV 257c623
Remove unused image file: ai-brand-insights-pre-launch.jpg
JorPV cdc9e6b
Update messages
JorPV f5cb7cd
Update comment for clarity
JorPV 7b0c530
refactor: remove disabled AI Brand Insights introduction classes
JorPV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
113 changes: 0 additions & 113 deletions
113
packages/js/src/introductions/components/modals/ai-brand-insights-free-trial.js
This file was deleted.
Oops, something went wrong.
111 changes: 0 additions & 111 deletions
111
packages/js/src/introductions/components/modals/ai-brand-insights-post-launch.js
This file was deleted.
Oops, something went wrong.
110 changes: 0 additions & 110 deletions
110
packages/js/src/introductions/components/modals/ai-brand-insights-pre-launch.js
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping it for consistency with the already-disabled
ai-brand-insights-pre-launch.js, which is likewise left in place (unreferenced) while its introduction is off. Makes re-enabling trivial and keeps the two AIBI modals symmetric.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: we've now deleted the unused component files (post-launch, free-trial, and the already-disabled pre-launch) as you suggested. The PHP introduction classes are intentionally kept (
should_show() => false) so their ids stay registered for the/introductions/{id}/seenroute — removing a class, unlike the dead view files, could break a Premium version that interacts with the introductions system (thread 🧵) .