Repository navigation
Conversation
…oms (NVIDIA#669) SQP-2: naming a tool in a catalog or quick-reference table (for example a bulk-execution tool) was treated as an action needing a user warning. Add a "Do NOT flag" case for markdown: only an instruction to use the tool selects an operation. SQP-3: readability idioms such as "in plain English" were treated as a forced output language. Add a "Do NOT flag" case: only an explicit instruction to produce output in a specific language or locale counts. Adds benign/risky fixture pairs that differ only in the deciding lines (sqp2_tool_catalog_clean / sqp2_tool_instructed and sqp3_plain_english_clean / sqp3_forced_language), clean-fixture tests in the existing style, and prompt-content tests for both exemptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nadir Ali <36660597+nadirali1350@users.noreply.github.com>
The SQP-2 catalog exemption is about naming a tool, not about what the skill itself does. In a live check on baselinker-automation, the first wording also dropped the finding about order and inventory data being routed through a third-party service. State that the exemption covers the listing only, so that warning stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Nadir Ali <36660597+nadirali1350@users.noreply.github.com>
Owner
Author
|
Closing: this was only to run CI on the fork. The real PR is NVIDIA#710. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal PR inside my fork, only to run the project's CI before opening the real PR upstream.