Skip to content

Removed text login to get kyc and added verified.#42

Open
Satishpethani92 wants to merge 1 commit intoXinFinOrg:masterfrom
Satishpethani92:small-fix-10-04-2026
Open

Removed text login to get kyc and added verified.#42
Satishpethani92 wants to merge 1 commit intoXinFinOrg:masterfrom
Satishpethani92:small-fix-10-04-2026

Conversation

@Satishpethani92
Copy link
Copy Markdown
Contributor

@Satishpethani92 Satishpethani92 commented Apr 10, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Updated the KYC verification section to consistently display verification status across the candidate profile.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

📝 Walkthrough

Walkthrough

The KYC section in the candidates view component was modified to display static "Verified" text instead of conditionally rendering links based on KYC status. Previously conditional markup for "Check here" and "Login to Get KYC" links is now commented out.

Changes

Cohort / File(s) Summary
KYC Status Display
app/components/candidates/View.vue
Changed KYC section from conditional link rendering (based on KYC.status) to always displaying static "Verified" text. Previous anchor elements are commented out.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A simple tweak, the KYC now gleams ✨
No more links or conditional schemes
Just "Verified" shines, clean and bright 🐰
Status checks fade into the night
One view, one truth, simple delight

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main changes made in the pull request: removing the 'Login to Get KYC' text and adding 'Verified' display in the KYC section UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/components/candidates/View.vue`:
- Around line 128-133: The template currently hardcodes "Verified"; change it to
render the real KYC-driven state by using the component's existing KYC
data/computed helpers (e.g., the KYC object, getCandidateData and getKYCStatus)
instead of the literal string: show "Verified" only when KYC.status is truthy,
otherwise show the same no-login link behavior used previously (or an
appropriate "Not verified" label), and keep links/targets consistent with the
original commented logic so the UI reflects real KYC status.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd5b8a17-4fa0-4247-8433-92191590b9b4

📥 Commits

Reviewing files that changed from the base of the PR and between 6043f69 and c7dc78f.

📒 Files selected for processing (1)
  • app/components/candidates/View.vue

Comment on lines +128 to +133
<!-- <a
v-if="Boolean(KYC.status)"
:href="KYC.url"
target="_blank">Check here</a>
<template v-else><a href="/setting">Login to Get KYC</a></template>
<template v-else><a href="/setting">Login to Get KYC</a></template> -->
Verified
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Do not hardcode KYC as always verified.

At Line 133, the UI now always shows Verified, but this component still computes real KYC state (getCandidateData at Line 887, getKYCStatus at Lines 1123-1135). This can misrepresent compliance state. Cross-file, the KYC flow is still active in app/components/candidates/Apply.vue (Lines 541-560, 557-590), so status should remain data-driven.

✅ Suggested fix (keep “no login link” behavior, but truthful status)
-                                            <!-- <a
-                                                v-if="Boolean(KYC.status)"
-                                                :href="KYC.url"
-                                                target="_blank">Check here</a>
-                                            <template v-else><a href="/setting">Login to Get KYC</a></template> -->
-                                            Verified
+                                            {{ Boolean(KYC.status) ? 'Verified' : 'Not Verified' }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<!-- <a
v-if="Boolean(KYC.status)"
:href="KYC.url"
target="_blank">Check here</a>
<template v-else><a href="/setting">Login to Get KYC</a></template>
<template v-else><a href="/setting">Login to Get KYC</a></template> -->
Verified
{{ Boolean(KYC.status) ? 'Verified' : 'Not Verified' }}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/components/candidates/View.vue` around lines 128 - 133, The template
currently hardcodes "Verified"; change it to render the real KYC-driven state by
using the component's existing KYC data/computed helpers (e.g., the KYC object,
getCandidateData and getKYCStatus) instead of the literal string: show
"Verified" only when KYC.status is truthy, otherwise show the same no-login link
behavior used previously (or an appropriate "Not verified" label), and keep
links/targets consistent with the original commented logic so the UI reflects
real KYC status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant