Add releasePlusNewBetas XcodeListCategory#403
Open
jayrhynas wants to merge 4 commits intoXcodesOrg:mainfrom
Open
Add releasePlusNewBetas XcodeListCategory#403jayrhynas wants to merge 4 commits intoXcodesOrg:mainfrom
releasePlusNewBetas XcodeListCategory#403jayrhynas wants to merge 4 commits intoXcodesOrg:mainfrom
Conversation
This adds a new filter option that shows only releases, plus any betas that do not have a release version. So as of today (July 7, 2023 the Xcode 15 betas will be shown but the Xcode 14 betas won't. Note that this will also show betas for older Xcode versions if necessary, for example if an Xcode 14.3.2 beta is released it will be shown until the mainline Xcode 14.3.2 is released.
MattKiazyk
requested changes
Nov 22, 2023
Contributor
MattKiazyk
left a comment
MattKiazyk
left a comment
There was a problem hiding this comment.
Thanks for spending the time! I like the idea - just some clean up to make it compile and the localization string.
| .labelStyle(TitleOnlyLabelStyle()) | ||
| .foregroundColor(.accentColor) | ||
| } | ||
| case .releasePlusBeta: |
Contributor
There was a problem hiding this comment.
There's some errors here around the name. Looks like you may have changed around the enum name and it's invalid here.
| } | ||
| case .releasePlusBeta: | ||
| if #available(macOS 11.3, *) { | ||
| Label("ReleasePlusBetaOnly", systemImage: "line.horizontal.3.decrease.circle.fill") |
Contributor
There was a problem hiding this comment.
This localized string does not exist
| "ReleaseOnly" = "Release only"; | ||
| "Beta" = "Beta"; | ||
| "BetaOnly" = "Beta only"; | ||
| "ReleasePlusNewBetas" = "Release & New Betas"; |
Contributor
There was a problem hiding this comment.
I think I like this one better - the only word is kind of redundant
Author
|
Thanks for looking it over! I'm not sure how I ended up committing the wrong enum names and localization keys there, sorry about that! |
# Conflicts: # Xcodes/Resources/en.lproj/Localizable.strings
Author
|
Fixed merge conflicts for Xcodes 2 update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new filter option that shows only releases, plus any betas that do not have a release version. So as of today (July 7, 2023 the Xcode 15 betas will be shown but the Xcode 14 betas won't. Note that this will also show betas for older Xcode versions if necessary, for example if an Xcode 14.3.2 beta is released it will be shown until the mainline Xcode 14.3.2 is released.
This is an implementation for the ideas discussed in #334
I do find the name "Releases & New Betas" to be a little long/wordy, both in the UI and in code. I'm open to suggestions for more succinct names. This also introduces new strings that will need to be localized.