Skip to content

Sponsor edge cases#7558

Open
PeterChen13579 wants to merge 5 commits into
XRPLF:xrplf/sponsorfrom
PeterChen13579:add_sponsor_edge_case_tests
Open

Sponsor edge cases#7558
PeterChen13579 wants to merge 5 commits into
XRPLF:xrplf/sponsorfrom
PeterChen13579:add_sponsor_edge_case_tests

Conversation

@PeterChen13579

@PeterChen13579 PeterChen13579 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

NFToken and LoanSet sponsor accounts only sponsor their designated Account, never a counterparty.
Added tests for each case, brokered NFT and LoanSet counterparty scoping, plus that sponsorship honors the free-trust-line allowance and the prefunded reserve budget.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari

mvadari commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@PeterChen13579 can you add a description for what issues you're fixing?

@mvadari mvadari requested review from Kassaking7 and mvadari June 16, 2026 20:51
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.2%. Comparing base (d1a77b4) to head (d10d4f8).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           xrplf/sponsor   #7558     +/-   ##
===============================================
- Coverage           82.2%   82.2%   -0.0%     
===============================================
  Files               1016    1016             
  Lines              78401   78411     +10     
  Branches            9012    9014      +2     
===============================================
+ Hits               64440   64447      +7     
- Misses             13952   13955      +3     
  Partials               9       9             
Files with missing lines Coverage Δ
src/libxrpl/ledger/helpers/MPTokenHelpers.cpp 96.5% <100.0%> (+<0.1%) ⬆️
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp 92.9% <100.0%> (ø)
src/libxrpl/tx/transactors/lending/LoanSet.cpp 90.5% <100.0%> (+0.1%) ⬆️
.../libxrpl/tx/transactors/nft/NFTokenAcceptOffer.cpp 93.9% <100.0%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PeterChen13579 PeterChen13579 marked this pull request as draft June 17, 2026 15:41
@PeterChen13579 PeterChen13579 marked this pull request as ready for review June 18, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants