Plugin Directory: Add common-plugin rejection reason for duplicate/common plugin submissions#569
Closed
davidperezgar wants to merge 2 commits intoWordPress:trunkfrom
Closed
Plugin Directory: Add common-plugin rejection reason for duplicate/common plugin submissions#569davidperezgar wants to merge 2 commits intoWordPress:trunkfrom
common-plugin rejection reason for duplicate/common plugin submissions#569davidperezgar wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
common-plugin rejection reason for duplicate/common plugin submissionscommon-plugin rejection reason for duplicate/common plugin submissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new rejection reason,
common-plugin, to better classify plugin submissions that repeat functionality already widely available in the directory.What changed
Template::get_rejection_reasons():common-pluginCommon plugincommon-plugininPlugin_Rejectedso the correct message is sent when selected._rejection_reasonlike other reasons.Why
We currently group these cases under broader reasons (often
otherorduplicate), which makes reporting and reviewer workflows less precise.common-plugingives us a clearer, explicit classification for submissions that are redundant in the directory.Testing
rejected.Common pluginappears in the rejection reason dropdown._rejection_reasonis stored ascommon-pluginin post meta.other).Notes