Replace strict ?int type hint with string|int|null union type for get_permalink() $original_id parameter

[Copilot]

GP_Route_Translation_Helpers::get_permalink() declares ?int $original_id but multiple callers pass strings — taxonomy term slugs from get_original_from_post_id(), untyped route parameters, DB object properties. This causes a fatal TypeError on PHP 8+.

The parameter is only used for string concatenation ($project_path . '/' . $original_id), so the strict int type was wrong.

• Replaced the ?int type hint with string|int|null union type (codebase targets PHP 8.1+)
• Removed a (int) cast workaround previously added in rewrite_original_post_type_permalink()

// Before
public static function get_permalink( string $project_path, ?int $original_id, ... ): string {

// After
public static function get_permalink( string $project_path, string|int|null $original_id, ... ): string {

---

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dd32.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[dd32]

LGTM, but @copilot we target PHP 8.1+ at present, so if there's a cleaner way here...

[dd32]

@copilot ? Follow up on above?

[Copilot]

@copilot ? Follow up on above?

Updated in 4281a90 to use the string|int|null union type now that I know the codebase targets PHP 8.1+.