Skip to content

Plugin Directory: Edit screen. Approve plugins with a double-click.#566

Open
frantorres wants to merge 1 commit intoWordPress:trunkfrom
frantorres:plugin-directory-approve-button
Open

Plugin Directory: Edit screen. Approve plugins with a double-click.#566
frantorres wants to merge 1 commit intoWordPress:trunkfrom
frantorres:plugin-directory-approve-button

Conversation

@frantorres
Copy link

@frantorres frantorres commented Mar 18, 2026

The “Approve” button when editing a plugin currently relies on JavaScript’s window.confirm() to prevent accidental or invalid clicks.

While window.confirm() is amazing for this purpose, it can become slow and frustrating when managing many plugins. Each action requires waiting for the browser to display a modal dialog, and interact with it. On top of that, many browsers enforce an additional pause before the dialog becomes interactive (ironically to prevent accidental clicks on the modal).

A double click also prevents invalid clicks and does not introduce any delay or context change.

To clarify that a double-click is needed, the text "Approve" changes to "Double-click to Approve" when clicked once.

image

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props frantorres.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant