Deprecate addslashes_gpc function and add unit tests. #10771
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
audrasjb
left a comment
audrasjb
left a comment
There was a problem hiding this comment.
Looks good to me as well.
|
@audrasjb @westonruter @mindctrl Thanks for the reviews. |
|
I'm happy to do so. |
This deprecates `addslashes_gpc()` in favor of `wp_slash()`, as the former is just a wrapper for the latter. The three remaining uses of `addslashes_gpc()` (in `WP_Query`) have been replaced with `wp_slash()`. Unit tests are added to verify that they have the same behavior. Developed in #10771 Follow-up to [23591], [23555]. Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion. See #21767. Fixes #64539. git-svn-id: https://develop.svn.wordpress.org/trunk@61590 602fd350-edb4-49c9-b593-d223f7449a82
This deprecates `addslashes_gpc()` in favor of `wp_slash()`, as the former is just a wrapper for the latter. The three remaining uses of `addslashes_gpc()` (in `WP_Query`) have been replaced with `wp_slash()`. Unit tests are added to verify that they have the same behavior. Developed in WordPress/wordpress-develop#10771 Follow-up to [23591], [23555]. Props rutviksavsani, audrasjb, westonruter, mindctrl, johnbillion. See #21767. Fixes #64539. Built from https://develop.svn.wordpress.org/trunk@61590 git-svn-id: http://core.svn.wordpress.org/trunk@60901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
4 participants
In this pull request, we are deprecating the
addslashes_gpcfunction as it was just a wrapper function towp_slashAdditionally, I have added PHPUnit tests for the same as well, let me know if they are not required and I can remove it.
Trac ticket: https://core.trac.wordpress.org/ticket/64539
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.