Skip to content

Fix blockGap output for block style variations.#10767

Closed
tellthemachines wants to merge 3 commits intoWordPress:trunkfrom
tellthemachines:fix/blockgap-for-variations
Closed

Fix blockGap output for block style variations.#10767
tellthemachines wants to merge 3 commits intoWordPress:trunkfrom
tellthemachines:fix/blockgap-for-variations

Conversation

@tellthemachines
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/64533

Changes from WordPress/gutenberg#74529.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

*/
$path_string = implode( '.', $value_path );
if (
isset( static::PROTECTED_PROPERTIES[ $path_string ] ) &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROTECTED_PROPERTIES should be removed altogether because it's not used anymore. I'm not sure if it's OK to remove outright - as I'm doing in WordPress/gutenberg#74529 - or if there's a way to deprecate it or something. In case some third party is extending the class and for some reason using that const?

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@tellthemachines tellthemachines force-pushed the fix/blockgap-for-variations branch from d0b1188 to 8d6350f Compare January 29, 2026 03:39
@tellthemachines tellthemachines marked this pull request as ready for review January 29, 2026 03:42
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props isabel_brison, aaronrobertshaw.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @tellthemachines 👍

✅ The changes match both WordPress/gutenberg#74529 & WordPress/gutenberg#75038
✅ New unit test looks good (thanks)

There was only one tiny issue I spotted and left a note on below but assuming that is tweaked, this LGTM!

🚢

Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61564
GitHub commit: e3ad7a0

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants