Fix blockGap output for block style variations.#10767
Fix blockGap output for block style variations.#10767tellthemachines wants to merge 3 commits intoWordPress:trunkfrom
Conversation
| */ | ||
| $path_string = implode( '.', $value_path ); | ||
| if ( | ||
| isset( static::PROTECTED_PROPERTIES[ $path_string ] ) && |
There was a problem hiding this comment.
PROTECTED_PROPERTIES should be removed altogether because it's not used anymore. I'm not sure if it's OK to remove outright - as I'm doing in WordPress/gutenberg#74529 - or if there's a way to deprecate it or something. In case some third party is extending the class and for some reason using that const?
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
ed2b11d to
bf859d9
Compare
d0b1188 to
8d6350f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
left a comment
There was a problem hiding this comment.
Thanks for putting this together @tellthemachines 👍
✅ The changes match both WordPress/gutenberg#74529 & WordPress/gutenberg#75038
✅ New unit test looks good (thanks)
There was only one tiny issue I spotted and left a note on below but assuming that is tweaked, this LGTM!
🚢
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Trac ticket: https://core.trac.wordpress.org/ticket/64533
Changes from WordPress/gutenberg#74529.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.