Reprint Server: Canonical plugin configuration with legacy migration. - #696
Conversation
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
2.88 s | 2.77 s | ⚪ +101 ms (+3.7%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
22.71 s | 23.02 s | ⚪ -313 ms (-1.4%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 25.59 s | 25.80 s | ⚪ -212 ms (-0.8%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
df1f82b to
40c936c
Compare
40c936c to
81ed61d
Compare
81ed61d to
7af243c
Compare
7af243c to
9415d2e
Compare
af940e8 to
f641be5
Compare
f641be5 to
dddeae4
Compare
dddeae4 to
9a73634
Compare
9a73634 to
de89cfb
Compare
| } | ||
| if (!defined(__NAMESPACE__ . '\\SECRET_FILE')) { | ||
| define(__NAMESPACE__ . '\\SECRET_FILE', PLUGIN_DIR . 'secret.php'); | ||
| if (!defined(__NAMESPACE__ . '\\CONNECTION_TOKEN_FILE')) { |
There was a problem hiding this comment.
A changelog entry would help the consumers of this code migrate. CC @WPprodigy @fredrikekelund for visibility for the next time this code is updated in Jetpack.
| -PHP_INT_MAX | ||
| ); | ||
|
|
||
| add_filter( |
There was a problem hiding this comment.
I have the same BC note here as in the previous PR in this stack. If we can avoid accumulating complexity, that's brilliant. If that will be too much of an inconvenience in Jetpack/wpcomsh/another consumer, then let's keep it. Any thoughts @fredrikekelund?
de89cfb to
a37cbfa
Compare
a37cbfa to
e89d0c5
Compare
Namespace and match the latest terminology in the plugin configuration, making sure old values are still read for backwards compatibility.