Skip to content

Reprint Server: Canonical plugin configuration with legacy migration. - #696

Merged
adamziel merged 4 commits into
trunkfrom
dotcom-18255-part-4
Sep 1, 2026
Merged

adamziel merged 4 commits into
trunkfrom
dotcom-18255-part-4

Conversation

@atanas-dev

@atanas-dev atanas-dev commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Namespace and match the latest terminology in the plugin configuration, making sure old values are still read for backwards compatibility.

@atanas-dev atanas-dev self-assigned this Aug 22, 2026
@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.10

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 2.88 s 2.77 s ⚪ +101 ms (+3.7%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 22.71 s 23.02 s ⚪ -313 ms (-1.4%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 25.59 s 25.80 s ⚪ -212 ms (-0.8%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

Comment thread reprint-server-wp/lib.php
}
if (!defined(__NAMESPACE__ . '\\SECRET_FILE')) {
define(__NAMESPACE__ . '\\SECRET_FILE', PLUGIN_DIR . 'secret.php');
if (!defined(__NAMESPACE__ . '\\CONNECTION_TOKEN_FILE')) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changelog entry would help the consumers of this code migrate. CC @WPprodigy @fredrikekelund for visibility for the next time this code is updated in Jetpack.

-PHP_INT_MAX
);

add_filter(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same BC note here as in the previous PR in this stack. If we can avoid accumulating complexity, that's brilliant. If that will be too much of an inconvenience in Jetpack/wpcomsh/another consumer, then let's keep it. Any thoughts @fredrikekelund?

@atanas-dev
atanas-dev force-pushed the dotcom-18255-part-4 branch from de89cfb to a37cbfa Compare August 31, 2026 16:11
Base automatically changed from dotcom-18255-part-3 to trunk September 1, 2026 00:16
@adamziel
adamziel force-pushed the dotcom-18255-part-4 branch from a37cbfa to e89d0c5 Compare September 1, 2026 00:16
@adamziel
adamziel merged commit 07b97ee into trunk Sep 1, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants