feat(privacy): add check for missing wp_privacy_personal_data_exporters registration#1292
Open
faisalahammad wants to merge 1 commit intoWordPress:trunkfrom
Open
Conversation
Add a new static check that warns plugin authors when their plugin handles personal data (user meta, comment meta, direct DB writes) but does not register a callback via the wp_privacy_personal_data_exporters filter. - New check class: Personal_Data_Exporter_Check - Registered in Default_Check_Repository under 'personal_data_exporter' - PHPUnit test class with three test cases - Test data plugins (with and without exporter registration) Fixes WordPress#1251
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new static check,
Personal_Data_Exporter_Check, that warns plugin authors when their plugin stores personal data (user meta, comment meta, or direct DB writes) but does not register an exporter callback via thewp_privacy_personal_data_exportersfilter. Since WordPress 4.9.6, plugins handling personal data are expected to hook into the Personal Data Export tool so site admins can fulfill GDPR data export requests.Fixes #1251
Changes
includes/Checker/Checks/Plugin_Repo/Personal_Data_Exporter_Check.php(new)A two-phase static file check:
add_user_meta,update_user_meta,add_comment_meta,update_comment_meta,$wpdb->insert/update/replace)add_filter( 'wp_privacy_personal_data_exporters', ... )— if absent, emit a severity-5 warningThe two-step approach avoids false positives on plugins that don't touch personal data at all.
includes/Checker/Default_Check_Repository.phpAfter:
Why: Registers the check under the
Plugin_Repocategory so it runs by default alongside other plugin directory compliance checks.Testing
Test 1: Plugin stores user meta, no exporter registered (expects warning)
update_user_meta()with no exporter filtermissing_personal_data_exporterappears ✅Test 2: Plugin stores user meta, exporter registered (expects clean)
update_user_meta()and registersadd_filter( 'wp_privacy_personal_data_exporters', ... )missing_personal_data_exporterwarning ✅Test 3: Plugin has no personal data handling (expects clean)
missing_personal_data_exporterwarning ✅PHPUnit test class added at
tests/phpunit/tests/Checker/Checks/Personal_Data_Exporter_Check_Tests.phpcovering all three scenarios.