Settings: open the Custom accent's colour wheel on its own swatch - #624
Merged
nuriapenya merged 1 commit intoAug 18, 2026
Merged
Conversation
The native colour wheel is a browser popup anchored to the box of the `<input type="color">` it belongs to, and the browser places it from the layout it has already computed. The input was measured and moved with an inline left/top one line before showPicker(), which leaves layout dirty, so the wheel was placed from the input's previous box: its static position at the start of the row, under the first swatch. Put the input in the Custom swatch's own cell and anchor it there in CSS instead. It sits on the swatch from first paint, so there is no dirty layout left to place it from, and it follows the swatch through window resize and grid reflow with nothing to measure.
nuriapenya
marked this pull request as ready for review
August 18, 2026 17:48
nuriapenya
deleted the
opensta-126-position-custom-color-picker-as-final-swatch
branch
August 18, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Open the Custom accent's colour wheel on the Custom swatch, instead of at the bottom left of the Accent color section.
The Custom swatch and its input now share a cell that is the last item of the accent row, anchored in CSS. The input is on the swatch from first paint, and it follows the swatch through window resize and grid reflow with nothing to measure.
Testing Instructions