Skip to content

Remove remaining legacy code#130

Merged
Wishmaster117 merged 2 commits intofeature/ace3-migrationfrom
feature/ace3-Milestone-8
Mar 29, 2026
Merged

Remove remaining legacy code#130
Wishmaster117 merged 2 commits intofeature/ace3-migrationfrom
feature/ace3-Milestone-8

Conversation

@Wishmaster117
Copy link
Copy Markdown
Owner

No description provided.

@Wishmaster117 Wishmaster117 merged commit a0997b0 into feature/ace3-migration Mar 29, 2026
4 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ac5c3a1a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +154 to +156
if self.window:IsShown() then
self.window:Show()
return
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Hide quest log window when toggle is called on open frame

In QuestLogFrame:Toggle, the branch for an already-visible window calls self.window:Show() and returns, so clicking the Quests button no longer closes the popup. This regresses the toggle behavior (it previously hid the frame in this state), which is user-visible every time the button is used to dismiss the quest log.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant