Skip to content

fix: avoid global warning handling changes - #1640

Merged
nijel merged 1 commit into
mainfrom
warnings
Sep 1, 2026
Merged

fix: avoid global warning handling changes#1640
nijel merged 1 commit into
mainfrom
warnings

Conversation

@nijel

@nijel nijel commented Aug 22, 2026

Copy link
Copy Markdown
Member

Stop changing process-wide warning handling when the library connects to localhost without TLS verification. Let urllib3 emit InsecureRequestWarning normally so concurrent requests cannot race while mutating shared warning state.

@nijel nijel self-assigned this Aug 22, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6b398a0f82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread wlc/client.py Outdated
Stop changing process-wide warning handling when the library connects to localhost without TLS verification. Let urllib3 emit InsecureRequestWarning normally so concurrent requests cannot race while mutating shared warning state.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T06:43:49.078817Z 74b225a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nijel
nijel enabled auto-merge (rebase) September 1, 2026 06:42
@nijel nijel changed the title fix: scope insecure request warning suppression fix: avoid global warning handling changes Sep 1, 2026
@nijel
nijel merged commit aa830a9 into main Sep 1, 2026
49 of 50 checks passed
@nijel
nijel deleted the warnings branch September 1, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant