Add script to generate relaxed atomics spec test #8220
+270
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
generate-spec-test
branch
from
2200bdf to
0c37e1b
Compare
stevenfontanella
changed the title
tlively
reviewed
Jan 20, 2026
rmahdav
reviewed
Jan 21, 2026
Member
Author
|
I had a mistake with the section's length calculation, which was only coincidentally correct when 2 instructions were being tested. I fixed it now and tested it locally with more ops. |
tlively
reviewed
Jan 21, 2026
Comment on lines
+115
to
+128
| def binary_test_example(): | ||
| return r'''(module binary | ||
| "\00asm\01\00\00\00" ;; header + version | ||
| "\01\05\01\60\00\01\7f\03\02\01\00\05\05\01\03\17\80\02" ;; other sections | ||
| "\0a\0c\01" ;; code section | ||
| "\0a\00" ;; func size + decl count | ||
| "\41\33" ;; i32.const 51 | ||
| "\fe\10" ;; i32.atomic.load | ||
| "\62" ;; 2 | (1<<5) | (1<<6): Alignment of 2 (32-bit load), with bit 5 set indicating that the next byte is a memory ordering | ||
| "\00" ;; memory index | ||
| "\01" ;; acqrel ordering | ||
| "\00" ;; offset | ||
| "\0b" ;; end | ||
| )''' |
Member
There was a problem hiding this comment.
It would be nice to have this level of detail (or more) in the comments for all binary modules. One way to do this would be to stamp out one module per instruction under test (or possibly one function per instruction) using the same template each time. If you put an unreachable before and after the instruction you won't need to change the template for different instruction types.
stevenfontanella
added a commit
that referenced
this pull request
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8165. test/spec/relaxed-atomics.wast was generated by the script.
Will add missing instructions e.g. load8, i64 instructions, etc once the approach looks good.