overhaul of testing suite and fix bug where rows dropped if no thumbnail - #92
Merged
Conversation
requirements.txt mirrored setup.py's install_requires but also carried pytest and pytest-timeout, while pytest-xdist, deepdiff and colorama were pip-installed ad hoc inside individual workflow steps. Nothing described what a test run needs, and the Dockerfile — which copies requirements.txt — pulled test tooling into the runtime image. Declare test-only dependencies in tests/requirements.txt and install both files in every CI job that runs tests. Also cap the load these jobs put on production VFB infra: a per-branch concurrency group on each live-backend workflow so superseded runs are cancelled, and a fixed -n 4 in place of -n auto (Run Tests) and -n 8 (Connectivity Tests) — the hosted runner has 4 vCPUs, so 8 workers bought no throughput and only doubled the concurrent queries aimed at Neo4j. cancel-in-progress is limited to pull_request on Performance Test, whose push and scheduled runs commit performance.md back to main.
Removing the "Class" gate on pub_syn changed get_term_info output for a large set of Individuals with nothing asserting it. Add an offline regression test built on a hand-made term_info document, so it exercises the parsing branch rather than whatever the graph currently holds: no backend, no skip path, no dependence on curation. Verified to fail with the gate restored. Also apply this branch's CI changes to the parked copy of performance-test.yml in docs/ci, so the parked definition does not go stale against the running one.
Contributor
Author
|
Thumbs up from claude:
|
The three execution tests carried @unittest.skip because Owlery /instances exceeded the 300s per-test budget for epFrag on every expression pattern tried. That was a server-side limitation and it has been fixed: the reference query (BFO_0000050 some VFBexp_FBtp0022557) now returns 5823 instances in about 4s, and all five tests in the file pass in ~7s. Note these were hard-coded skips, not the connection-failure skips conftest.py applies — no amount of backend recovery would have un-skipped them on its own.
Robbie1977
approved these changes
Aug 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.