Repository navigation
Conversation
Follow-up to ViaVersion#128. ViaVersion#128 mapped the 1.9 `entity.player.attack.*` sounds to arrow sounds for 1.8 clients: - `attack.crit`, `knockback`, `strong`, `sweep`, `weak` → `random.successful_hit` (the arrow-hit "ding") - `attack.nodamage` → `random.bowhit` (arrow landing) Since these are sent on every melee hit, 1.8 clients now hear arrow sounds constantly during PvP. Hits in creative, or any other hit that deals no damage, sound like arrows landing nearby, and the arrow-hit "ding" no longer tells you whether a bow shot actually hit. 1.8 has no attack sounds. The only sound on a hit is the victim's hurt sound, which is still sent separately as `entity.player.hurt` → `game.player.hurt`. This PR sets the six `entity.player.attack.*` entries back to `""`, as they were before ViaVersion#128, so melee hits sound like vanilla 1.8 again. Only `mappings/diff/mapping-1.9to1.8.json` is changed. I didn't recompile the output files. Tested on a 1.12.2 server with ViaVersion/ViaBackwards 5.12.0 and ViaRewind 4.2.0, using a 1.8 client. Fixes ViaVersion/ViaRewind#726
Beaness
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #128.
#128 mapped the 1.9
entity.player.attack.*sounds to arrow sounds for 1.8 clients:attack.crit,knockback,strong,sweep,weak→random.successful_hit(the arrow-hit "ding")attack.nodamage→random.bowhit(arrow landing)Since these are sent on every melee hit, 1.8 clients now hear arrow sounds constantly during PvP. Hits in creative, or any other hit that deals no damage, sound like arrows landing nearby, and the arrow-hit "ding" no longer tells you whether a bow shot actually hit.
1.8 has no attack sounds. The only sound on a hit is the victim's hurt sound, which is still sent separately as
entity.player.hurt→game.player.hurt. This PR sets the sixentity.player.attack.*entries back to"", as they were before #128, so melee hits sound like vanilla 1.8 again.Only
mappings/diff/mapping-1.9to1.8.jsonis changed. I didn't recompile the output files.Tested on a 1.12.2 server with ViaVersion/ViaBackwards 5.12.0 and ViaRewind 4.2.0, using a 1.8 client.
Fixes ViaVersion/ViaRewind#726