Skip to content

[arch/x86] Intel APX support #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nullableVoidPtr wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

[arch/x86] Intel APX support #6423

nullableVoidPtr wants to merge 6 commits into from
+987 −255

Conversation

@nullableVoidPtr
Copy link
Contributor

@nullableVoidPtr nullableVoidPtr commented Feb 17, 2025 •
edited
Loading

  • EGPRs
  • JMPABS
  • Push/Pop
    • PUSH2
    • PUSHP
    • POP2
    • POPP
  • CCMPSCC
  • CFCMOVCC
  • CTESTSCC
  • SETCC
  • Zero Upper
    • IMUL
    • SETCC
  • New Data Destination

Resolves #5246

@xusheng6
Copy link
Member

xusheng6 commented Mar 10, 2025

@nullableVoidPtr thx for your work! Please let me know when you think the code is ready for reviewer!

@galenbwill galenbwill self-assigned this May 7, 2025
@galenbwill galenbwill added Arch: x86 Issues with the x86/x64 architecture plugin Type: Enhancement Component: Architecture Issue needs changes to an architecture plugin Impact: Low Issue is a papercut or has a good, supported workaround Effort: Medium Issues require < 1 month of work State: Blocked (Customer) Issue is blocked on waiting for a response from a customer labels May 7, 2025
@galenbwill galenbwill added this to the Future milestone May 7, 2025
@galenbwill galenbwill changed the title [arch/x86] Intel APX support [arch/x86] [WIP] Intel APX support May 7, 2025
@galenbwill galenbwill removed their assignment Aug 6, 2025
@psifertex psifertex marked this pull request as draft October 23, 2025 20:20
emesare
emesare reviewed Dec 1, 2025
View reviewed changes
@emesare
Copy link
Member

emesare commented Dec 1, 2025

The push / pop lifting looks fine on the binary https://github.com/user-attachments/files/23866882/apxbin.zip

@emesare
Copy link
Member

emesare commented Dec 1, 2025

image

CCMP also looks correct, the conditional CMP block and the DFV write block look fine.

@nullableVoidPtr
Copy link
Contributor Author

nullableVoidPtr commented Dec 2, 2025

Thanks for the test bin - I'll be sure to test against that; do you have a corpus for the other extension instructions?

@nullableVoidPtr nullableVoidPtr marked this pull request as ready for review December 3, 2025 08:50
@stong
Copy link

stong commented Dec 3, 2025

👏

@emesare
Copy link
Member

emesare commented Dec 3, 2025

Thanks for the test bin - I'll be sure to test against that; do you have a corpus for the other extension instructions?

I do not, I will make another with more of the extensions instructions expressed, thank you for responding quick!

@emesare emesare self-assigned this Dec 3, 2025
@emesare emesare removed the State: Blocked (Customer) Issue is blocked on waiting for a response from a customer label Dec 3, 2025
@emesare emesare modified the milestones: Future, Jotunheim Dec 3, 2025
@nullableVoidPtr nullableVoidPtr changed the title [arch/x86] [WIP] Intel APX support [arch/x86] Intel APX support Dec 4, 2025
@nullableVoidPtr
Copy link
Contributor Author

nullableVoidPtr commented Jan 25, 2026

Heya, I consider this extension complete - is there any other blockers besides your testing?

@emesare
Copy link
Member

emesare commented Jan 26, 2026

Heya, I consider this extension complete - is there any other blockers besides your testing?

None, just have not merged it yet, will get it done shortly, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emesare emesare emesare left review comments

Assignees

@emesare emesare

Labels

Arch: x86 Issues with the x86/x64 architecture plugin Component: Architecture Issue needs changes to an architecture plugin Effort: Medium Issues require < 1 month of work Impact: Low Issue is a papercut or has a good, supported workaround

Projects

None yet

Milestone

Jotunheim

Development

Successfully merging this pull request may close these issues.

Add support for Intel APX

6 participants

@nullableVoidPtr @xusheng6 @emesare @stong @plafosse @galenbwill