Fix parsePattern to return Ok when iterator empty with named param#641
Open
cuiweixie wants to merge 1 commit intoValeLang:masterfrom
Open
Fix parsePattern to return Ok when iterator empty with named param#641cuiweixie wants to merge 1 commit intoValeLang:masterfrom
cuiweixie wants to merge 1 commit intoValeLang:masterfrom
Conversation
Without return, the Ok(...) in the !iter.hasNext branch was discarded and parsing continued past the early-exit case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
parsePattern, when!iter.hasNextandmaybeNameFromParameterisSome, the branch built anOk(PatternPP(...))but did notreturn. In Scala that value is only the result of the innermatch; execution then fell through and continued parsing, which is wrong for this exhausted-input case.Add
returnso the function exits with the intendedOkresult.Testing