Skip to content

Bugfix pk self mapping #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanrdoherty merged 2 commits into from
Oct 9, 2026
Merged

Bugfix pk self mapping #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
223f7fe
Don't translate PK after looking up mapping in alias query/plugin; tr…
ryanrdoherty Oct 8, 2026
9b93acc
Merge branch 'master' into bugfix-pk-self-mapping
ryanrdoherty Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Model/src/main/java/org/gusdb/wdk/model/record/DynamicRecordInstance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ public class DynamicRecordInstance extends StaticRecordInstance {

public DynamicRecordInstance(User user, RecordClass recordClass, Map<String, Object> pkValues)
throws WdkModelException, WdkUserException {
super(user, recordClass, recordClass, pkValues, true);
this(user, recordClass, pkValues, true);
}

public DynamicRecordInstance(User user, RecordClass recordClass, Map<String, Object> pkValues, boolean translatePk)
throws WdkModelException, WdkUserException {
super(user, recordClass, recordClass, pkValues, translatePk);
_user = user;
}

Expand Down
2 changes: 1 addition & 1 deletion Model/src/main/java/org/gusdb/wdk/model/record/RecordClass.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public static List<RecordInstance> getRecordInstances(User user, PrimaryKeyValue
RecordClass recordClass = pkValue.getPrimaryKeyDefinition().getRecordClass();
return mapToList(
recordClass.lookupPrimaryKeys(user, pkValue.getRawValues()),
fSwallow(idMap -> new DynamicRecordInstance(user, recordClass, idMap)));
fSwallow(idMap -> new DynamicRecordInstance(user, recordClass, idMap, false)));
}
catch (RecordNotFoundException rnfe) {
return Collections.emptyList();
Expand Down
Loading