Skip to content

Unify integration icons on one component - #1877

Draft
RhysSullivan wants to merge 2 commits into
mainfrom
integration-icons
Draft

Unify integration icons on one component#1877
RhysSullivan wants to merge 2 commits into
mainfrom
integration-icons

Conversation

@RhysSullivan

Copy link
Copy Markdown
Collaborator

The "Add an integration" browse page rendered a bare-letter avatar for Codex
plugin presets: its private RowIcon fed the preset's authenticated
executor: icon path into a raw <img> (which can never load it) and never
consulted the preset's public fallback image. The command palette had its own
separate component that did this correctly — two resolvers for the same icon.

  • IntegrationFavicon is now the one canonical component: explicit icon
    (including executor:-scheme paths resolved through the authenticated local
    API) → explicit fallback image → bundled local icon → favicon derived from
    the integration URL → neutral BoxIcon. Gains fallbackSrc and
    className.
  • The browse page's three row kinds (presets, registry, installed), the
    command palette, and the Codex plugin add screen all render through it.
    RowIcon and PresetIcon are deleted.
  • The installed rows' hand-rolled copy of the cascade is gone with them.

e2e: the Codex plugins scenario now opens the browse page in a real browser
and asserts the Computer Use card shows its product icon.

browse page with real Computer Use icon

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
executor-cloud efe999f Aug 30 2026, 05:40 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 30, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
executor-marketing efe999f Commit Preview URL

Branch Preview URL
Aug 30 2026, 05:40 AM

@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare preview

Console https://executor-preview-pr-1877.executor-e2e.workers.dev
MCP https://executor-preview-pr-1877.executor-e2e.workers.dev/mcp
Deployed commit efe999f

Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes.

@pkg-pr-new

pkg-pr-new Bot commented Aug 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

@executor-js/cli

npm i https://pkg.pr.new/@executor-js/cli@1877

@executor-js/config

npm i https://pkg.pr.new/@executor-js/config@1877

@executor-js/execution

npm i https://pkg.pr.new/@executor-js/execution@1877

@executor-js/sdk

npm i https://pkg.pr.new/@executor-js/sdk@1877

@executor-js/codemode-core

npm i https://pkg.pr.new/@executor-js/codemode-core@1877

@executor-js/runtime-quickjs

npm i https://pkg.pr.new/@executor-js/runtime-quickjs@1877

@executor-js/plugin-file-secrets

npm i https://pkg.pr.new/@executor-js/plugin-file-secrets@1877

@executor-js/plugin-graphql

npm i https://pkg.pr.new/@executor-js/plugin-graphql@1877

@executor-js/plugin-keychain

npm i https://pkg.pr.new/@executor-js/plugin-keychain@1877

@executor-js/plugin-mcp

npm i https://pkg.pr.new/@executor-js/plugin-mcp@1877

@executor-js/plugin-onepassword

npm i https://pkg.pr.new/@executor-js/plugin-onepassword@1877

@executor-js/plugin-openapi

npm i https://pkg.pr.new/@executor-js/plugin-openapi@1877

executor

npm i https://pkg.pr.new/executor@1877

commit: efe999f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant