Unify integration icons on one component - #1877
Draft
RhysSullivan wants to merge 2 commits into
Draft
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | efe999f | Aug 30 2026, 05:40 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | efe999f | Commit Preview URL Branch Preview URL |
Aug 30 2026, 05:40 AM |
Contributor
Cloudflare preview
Sign-in is Cloudflare Access (one-time PIN to an allowed email). The preview has its own database and encryption key; it is destroyed when this PR closes. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Add an integration" browse page rendered a bare-letter avatar for Codex
plugin presets: its private
RowIconfed the preset's authenticatedexecutor:icon path into a raw<img>(which can never load it) and neverconsulted the preset's public fallback image. The command palette had its own
separate component that did this correctly — two resolvers for the same icon.
IntegrationFaviconis now the one canonical component: explicit icon(including
executor:-scheme paths resolved through the authenticated localAPI) → explicit fallback image → bundled local icon → favicon derived from
the integration URL → neutral
BoxIcon. GainsfallbackSrcandclassName.command palette, and the Codex plugin add screen all render through it.
RowIconandPresetIconare deleted.e2e: the Codex plugins scenario now opens the browse page in a real browser
and asserts the Computer Use card shows its product icon.