Adds AV Tests and Caption Functionality#1796
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| return typeGroup === "audio" || typeGroup === "video"; | ||
| } | ||
|
|
||
| // vtt, srt, csv |
There was a problem hiding this comment.
Was unable to find support for csv.
| return false; | ||
| } | ||
|
|
||
| const captionTypes = new Set<String>(["text/vtt", "text/srt"]); |
There was a problem hiding this comment.
Did not lose this. It's just higher up in the file now - https://github.com/UniversalViewer/universalviewer/pull/1796/changes#diff-cb64973a8a5a2e0eac4714d6ee79b3016b2f2e7b76e35a803c9f28b4bf197b16R30
|
Thanks, @K8Sewell, this is great! I haven't had a chance to look closely since I'm preparing to leave for my trip and need to choose my battles -- but I'll be happy to look closer when I get back if you want me to. In the meantime, I imagine that @LanieOkorodudu might be a good candidate for reviewing, since she's been more heavily involved in test code lately and probably has some good insights! |
| }); | ||
| }, 60000); | ||
|
|
||
| it("loads the AV manifest into the mediaelement player", async () => { |
There was a problem hiding this comment.
@K8Sewell, Thanks for putting this together, Do you think it's worth adding the canvas title displays "Video Example 3", and that the video can actually play, continue for around 10 seconds, and then pause successfully.
| }); | ||
|
|
||
| // Play/pause button. | ||
| const playButton = await avPage.$( |
There was a problem hiding this comment.
Same here, like play for 10 seconds and and pause to confirm the video is actually play for seconds.
| }); | ||
| }, 60000); | ||
|
|
||
| it("loads the AV manifest into the AV center panel", async () => { |
There was a problem hiding this comment.
Also confirmed that the title has "Preludio e Coro d'introduzione – Bel conforto al mietitore" as it loaded.
|
I really like the approach of creating a separate folder for each component to test. It makes everything much easier to maintain. Thanks! @K8Sewell |
3 participants
Description of what you did:
Related Issue
#1750