Simulation step: emitted events and on-demand storage slot changes - #34
Simulation step: emitted events and on-demand storage slot changes#34gretzke wants to merge 4 commits into
Conversation
david-uniswap
left a comment
There was a problem hiding this comment.
Ran the core deployment suites (219 pass) and the checklist frontend tests (6 pass) locally. Event capture on both tiers, the 4byte proxy with negative caching and in-flight coalescing, and the single-flight storage trace endpoint all look right.
One non-blocking thing worth a follow-up: the fork replay in storageSlotChanges awaits each receipt but never checks receipt.status. If a prerequisite tx (or the target itself) reverts on the fork, the endpoint returns a diff that reads as "no storage slots changed" instead of an error. Low risk since the button only shows after a successful simulation of the same schedule, but checking status and erroring on a reverted replay would make the result trustworthy on its own.
Minor UX note, fine as is: the single storageLoading flag makes every step's button show the loading label while one trace runs, which at least matches the server's single-flight behavior.
Each simulated step in the review checklist now shows its emitted events, and storage slot changes can be requested per step.
Events:
Storage slot changes (the original issue):
Closes #21.