accessibility: add missing AutomationProperties.Name to unlabeled buttons#3283
Open
reabr wants to merge 2 commits into
Open
accessibility: add missing AutomationProperties.Name to unlabeled buttons#3283reabr wants to merge 2 commits into
reabr wants to merge 2 commits into
Conversation
|
|
…tons - ComposerHeaderCancel: reuse AccDescrCancelReply - ButtonEditor: reuse AccDescrPhotoEditor - ButtonTimer: new AccDescrSetTimer string - ButtonManage: reuse Cancel - ButtonForward: reuse Forward - ButtonDelete: reuse Delete - DeleteButton (ChatRecordBar): new AccDescrCancelRecording - RemoveButton (ChatActionBarView): new AccDescrDismissBar - BackButton/ForwardButton (TabbedPage): reuse AccDescrGoBack / new AccDescrGoForward - Menu (GroupCallPage): reuse AccDescrMoreOptions Fixes screen reader announcements for icon-only buttons that were previously read as just 'Button'.
reabr
force-pushed
the
accessibility/add-missing-automation-names
branch
from
41e4fc1 to
08efa1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several icon only buttons across the app have no AutomationProperties.Name,
causing screen readers like Narrator and NVDA to announce them as just "Button"
with no context.
Changes
New strings in Resources.resw
XAML fixes
Testing
Tested with Windows Narrator (Win+Ctrl+Enter).
All buttons now announce their purpose correctly.