Add retry to coursebook scraper#155
Draft
justinschwerdtfeger wants to merge 10 commits intodevelopfrom
Draft
Conversation
PR to move coursebook error retry to branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was moved from a fork to a branch
This PR aims to add retry for the coursebook scraper. It's mostly intended for network errors, so scraping can continue even if something goes wrong. it aims to use user-provided flags to control some error handling logic (retry count, retry wait time, retry on panic).
Nothing in coursebook.go should execute log.fatal anymore. In most cases, this PR just returns the error until it reaches main, where we can add some recovery logic based on user-provided flags
All log.Fatals are removed and most are swapped with log.Panic as log.Fatal is not recoverable.
In addition, more instances of exponential backoff for network-related issues have been added, along with a generic retry for any other errors.