Skip to content

Refactor course-section references to use compound keys#152

Open
n-tennyson wants to merge 1 commit intocompound-keyfrom
refactor-parser-compound-keys
Open

Refactor course-section references to use compound keys#152
n-tennyson wants to merge 1 commit intocompound-keyfrom
refactor-parser-compound-keys

Conversation

@n-tennyson
Copy link
Copy Markdown
Contributor

Summary

This PR updates the course-section relationship in api-tools to use compound keys instead of partial references.

Changes

  • Courses now store sections using full SectionKey
  • Sections reference courses using CourseKey
  • Fixed a bug in validator.go where invalid references could be skipped
  • Updated parser tests and fixtures to match the new structure

Notes

  • All tests pass (go test ./...)
  • This only covers the course/section refactor
  • Professor-section changes are handled separately (ProfSectionKey not modified)

@n-tennyson n-tennyson requested a review from mikehquan19 April 2, 2026 23:00
@KBui4
Copy link
Copy Markdown
Contributor

KBui4 commented Apr 3, 2026

I haven't looked into this in too much detail, but I did notice that the TestSectionReferenceProfFail case was removed for seemingly no reason. I don't think that test should be deleted, but if it is causing issues, you could comment it out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants