Refactor course-section references to use compound keys#152
Open
n-tennyson wants to merge 1 commit intocompound-keyfrom
Open
Refactor course-section references to use compound keys#152n-tennyson wants to merge 1 commit intocompound-keyfrom
n-tennyson wants to merge 1 commit intocompound-keyfrom
Conversation
Contributor
|
I haven't looked into this in too much detail, but I did notice that the TestSectionReferenceProfFail case was removed for seemingly no reason. I don't think that test should be deleted, but if it is causing issues, you could comment it out for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the course-section relationship in
api-toolsto use compound keys instead of partial references.Changes
SectionKeyCourseKeyvalidator.gowhere invalid references could be skippedNotes
go test ./...)ProfSectionKeynot modified)