Add unit tests for api-tools/parser/gradeLoader #44 (#118)#148
Merged
mikehquan19 merged 2 commits intodevelopfrom Apr 2, 2026
Merged
Add unit tests for api-tools/parser/gradeLoader #44 (#118)#148mikehquan19 merged 2 commits intodevelopfrom
mikehquan19 merged 2 commits intodevelopfrom
Conversation
* cleanup loader poc test * Cleaned up gradeLoader code and updated parser tests to use grade data * New testcase * Added unit tests for gradeLoader.go, added more test data, minor fix validator test * fix whitespace error, fix logging --------- Co-authored-by: SoggyRihno <94922205+SoggyRihno@users.noreply.github.com> Co-authored-by: Mike Quan <hoangphucquan19@gmail.com>
mikehquan19
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as the old pr but now merging from a branch:
Made grade loader return map, error (formerly used global var)
Made grade loader use provided log file instead of assuming ./logs/
Reduced logging from 1 log file per file to just log to defualt (std out + main log file)
Made missing optional column logging verbose
Changed the updater flag so that it no longer nukes the whole
testdatadir, this means PRs shouldn't be as bloated with test dataThere was a small issue where course descriptions could have extra white space.