Density estimation features - #403
Draft
yentyu wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft pull request for some of the modifications discussed here which will allow for different density estimation techniques.
Among the major modifications:
sample.evaluate_pdfandsample.evaluate_marginal_pdfhave been altered to evaluate different pdfs. Previously, prob_type "kde" only evaluated marginal clustered kdes. This has been changed to "kde_marginals". Now prob_type "kde" expects a scipy.stats.gaussian_kde object for evaluation. Other prob_types have been introduced.calculateR. The goal of this function is to provide a framework to apply alternative methods for output density estimation and save these density objects for evaluation in thesample_set_baseobjects using their native prob_type and prob_parameters attributes. "generate_densities" will be a wrapper function and should be flexible enough for new methods of density estimation to be applied.calculateR.invertwill have an option to call generate_densities with using different kinds of methods.