-
Notifications
You must be signed in to change notification settings - Fork 8
Fix the year and add a schedule to run the tests on Jan 2nd each year. #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
So we at least notice the fail.
matt-graham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that coming up with a better long term solution would be good but also that at least having a noisy warning to remind us is an improvement over the current situation. Have suggested possibly making comment explaining why we have added this schedule line a bit more explicit to not confuse future us, but ambivalent as to whether this is needed to approving now. Thanks for fixing @samcunliffe!
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
for more information, see https://pre-commit.ci
|
I have an action that updates the licences automatically every year |
|
FYI: TYIL (This Year I Learned): Python’s new recommendation to only include the year of creation (and not the current year) in copyrights.
|
Regression tests are dumb. And years change.
I'd love it if we could find a way not to have the full-output regression test.
Failing that, I'm proposing a
cronso that we at least get an email on the 2nd January, which reminds us to fix the year. I acknowledge that it's a dumb solution, but it's a dumb problem: so fairs fair.