Bring back workaround for Scintilla IME support#582
Merged
arch1t3cht merged 1 commit intomasterfrom Apr 3, 2026
Merged
Conversation
This was initially added in fffb138 but removed in c487dd2 since it uses private wxWidgets APIs and hence does not work when linking system wxWidgets. However, without this workaround, the IME is completely nonfunctional in the subtitle edit control on Mac. The proper solution here would be to add IME support in wxStyledTextCtrls in wxWidgets, but this is a larger undertaking that will take more time. For the time being, we can bring back this workaround but only enable it when we're building wxWidgets as a subproject, which the GitHub CI does. With this hack enabled, the IME is still a bit janky, especially when pressing backspace, but at least it is *possible* to use it on Mac now. Fixes #318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was initially added in fffb138 but removed in c487dd2 since it uses private wxWidgets APIs and hence does not work when linking system wxWidgets.
However, without this workaround, the IME is completely nonfunctional in the subtitle edit control on Mac. The proper solution here would be to add IME support in wxStyledTextCtrls in wxWidgets, but this is a larger undertaking that will take more time. For the time being, we can bring back this workaround but only enable it when we're building wxWidgets as a subproject, which the GitHub CI does.
With this hack enabled, the IME is still a bit janky, especially when pressing backspace, but at least it is possible to use it on Mac now.
Fixes #318
PR created to test CI