fix(interview): don't duplicate the ask in a validation re-ask#26
Merged
Conversation
added 2 commits
June 14, 2026 18:26
A validator that returns a complete-sentence error already re-asks for the value (e.g. "Please provide a phone number with at least 7 digits."). validation_guidance_directive still appended the original field question, producing a repetitive reply: "Please provide a phone number with at least 7 digits. What is your WhatsApp mobile number?". Treat an error ending in . ! or ? (or prefixed Tell the user:/Ask:) as self-contained and skip the question; only terse fragments (e.g. the "Invalid value" fallback) still get the question appended for context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A validator that returns a complete-sentence error already re-asks for the value (e.g.
"Please provide a phone number with at least 7 digits.").validation_guidance_directivestill appended the original field question, producing a repetitive reply:Fix
Treat an error ending in
.!?(or prefixedTell the user:/Ask:) as a self-contained re-ask and skip the question. Only terse fragments (e.g. theInvalid valuefallback) still get the question appended for context.Tests
Adds
tests/action/interview/test_validation_reask.py(complete-sentence not duplicated, terse fragment still appended,?-ending self-contained, prefixed-error strip). Interview suite green.