deps(rust): bump gotatun from 0.7.2 to 0.8.1 in /wgbridge-rs#668
Merged
Conversation
gotatun 0.8.0 removed the public `impl AsFd for UdpSocket` that we relied on to obtain the outbound UDP socket fd for `VpnService.protect()`, which blocked #632. gotatun 0.8.1 restores a public accessor: `UdpSocket::socket()` returns the inner `tokio::net::UdpSocket`, so we protect its fd through that while keeping gotatun's optimized sendmmsg/recvmmsg datapath. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SWerf5epj7WPqUHR9p8dL1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
gotatunfrom 0.7.2 to 0.8.1 inwgbridge-rs, unblocking #632.Background
#632 (bump to 0.8.0) was deferred because gotatun 0.8.0 made
UdpSocket'sinner socket an opaque enum and removed the public
impl AsFd for UdpSocket.That accessor was how we obtained the outbound UDP socket's fd to hand to
Android's
VpnService.protect()— our loop-prevention path. A workaroundwould have regressed gotatun's optimized
sendmmsg/recvmmsg+ GRO datapathto per-packet I/O, so the bump was deferred pending an upstream public fd
accessor (filed as mullvad/gotatun#165).
What changed
gotatun 0.8.1 restores a public accessor:
UdpSocket::socket()returnsio::Result<&tokio::net::UdpSocket>, exposing the inner tokio socket. This letsus obtain the fd through it while keeping gotatun's optimized batched datapath
intact.
Cargo.toml/Cargo.lock:gotatunpinned to=0.8.1(pulls in thetracingtransitive deps that replacedlogin 0.8.0).transport/udp.rs:ProtectedUdpFactory::protectnow derives the fd viasocket.socket()?.as_raw_fd()instead of the removedAsFdimpl.Verification
cargo check— compiles cleanly.cargo test— all 21 host tests pass.🤖 Generated with Claude Code
Generated by Claude Code