TIG-207: implement info icon that shows important links#516
TIG-207: implement info icon that shows important links#516angelina-ji merged 4 commits intomasterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a4a7c2956
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| reqLabel, | ||
| popoverInstance, | ||
| { | ||
| hideDelayMs: 0, |
There was a problem hiding this comment.
Using hideDelayMs: 0 causes bindManualHoverPopover to run the hide check immediately on trigger mouseleave, so when the pointer crosses the trigger→popover gap and relatedTarget is null, the popover is hidden before users can reach interactive content. This regresses existing behavior for sub-requirement popovers (notably the Find Satisfying Courses button) and can also affect the new header-link popovers; a small delay is needed to make hover-to-popover transitions reliable.
Useful? React with 👍 / 👎.
| className="fa fa-info-circle info-icon" | ||
| data-bs-toggle="popover" | ||
| data-bs-html="true" | ||
| data-bs-content={popoverContent} | ||
| style={{ marginLeft: '5px', cursor: 'pointer' }} |
There was a problem hiding this comment.
The new info icon is rendered inside .tree-view_item, but it is not treated as an interactive target by the row click handler (makeNodesClickable only excludes links/buttons/inputs), so clicking the icon also toggles expand/collapse of the requirement node. On pointer-driven use, this makes the icon interaction unexpectedly mutate tree state instead of acting as an isolated info affordance.
Useful? React with 👍 / 👎.
2 participants
No description provided.