feat: Add SGD, Momentum, and Adam with same-net comparison - #6
Merged
Conversation
ThomasHartDev
commented
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three standard first-order optimizers as pure numpy update rules that sit next to the hand-written MLP backprop. Each class owns its own state (velocity for momentum, bias-corrected moments for Adam) and steps a flat list of parameter arrays in place, so the training loop can swap rules without touching the gradient math.
compare_optimizersretrains the same architecture on the same data with the same seed for each factory, which keeps init and minibatch order fixed. On XOR all three cut loss; Adam usually pulls ahead early because the adaptive rates absorb uneven gradient scale. Defaults match the common library settings so the curves are easy to reason about against PyTorch.