feat: Add self-verification with verified:true only on assertion pass - #6
Open
ThomasHartDev wants to merge 1 commit into
Open
feat: Add self-verification with verified:true only on assertion pass#6ThomasHartDev wants to merge 1 commit into
ThomasHartDev wants to merge 1 commit into
Conversation
Split post-condition checking into a pure selfVerify phase and tag every RunResult with a literal verified flag so trusted values only appear when the caller-supplied assertion holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every RunResult now carries a literal verified flag, and verified:true only appears when the caller-supplied post-condition passes. Verification is its own pure phase in src/verify.ts (selfVerify, allAssertions/anyAssertion, optional reason on failure) so the vm and worker runners just hand the produced value in and never invent trust from a successful execute alone. isVerified narrows on verified:true, and the suite covers pass/fail, reasons, composition, and the failure modes that must stay unverified.