tweak(controlbar): Decouple the general promotion star blink from the render frame rate

[bobtista]

Addresses #2834, same idea as #2833 / #2056.

Problem

The general's promote-button stars blink faster as you raise render FPS, because the blink is driven off the logic frame (TheGameLogic->getFrame()) and re-checked every render frame. The blink rate should be constant regardless of render FPS / logic time scale.

Fix

ControlBar::getStarImage() now paces the star highlight off of TheFramePacer->getUpdateTime(), so the blink rate is constant regardless of render FPS / logic time scale. The star keeps blinking while the game is paused.

TODO:

[x] Testing
[x] Replicate to Generals

[greptile-apps]

Greptile Summary

Decouples the general-promotion star blink rate from both render FPS and logic time scale by replacing the getFrame() % LOGICFRAMES_PER_SECOND modulo check with a wall-clock accumulator driven by TheFramePacer->getUpdateTime().

• A new Real m_genStarFlashTimeAccumulator field is added to ControlBar, initialized to 0.0f in the constructor, and advanced each render frame only when the star is actively flashing; the accumulator is wrapped modulo 1 second, and the second half of each cycle shows the highlight image.
• FramePacer.h is included in ControlBar.cpp and the include is in alphabetical order, consistent with the surrounding block.

Confidence Score: 5/5

Safe to merge — the change is a self-contained UI timing fix with correct initialization, accumulation, and wrap logic.

The accumulator is initialized to zero in the constructor, advanced only when the star is actively flashing, and correctly wrapped modulo 1 second each render frame. TheFramePacer->getUpdateTime() measures real elapsed render time, so the blink rate is truly independent of both render FPS and logic time scale. No shared mutable state, no allocation, and the early-return path when m_genStarFlash is false is unchanged.

No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Include/GameClient/ControlBar.h	Adds m_genStarFlashTimeAccumulator (Real) member to ControlBar with an inline doc comment; clean header change.
Core/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp	Replaces frame-count modulo blink with a wall-clock accumulator driven by TheFramePacer->getUpdateTime(); initialization, wrap logic, and half-cycle check are all correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["getStarImage() called\n(each render frame)"] --> B{m_genStarFlash?}
    B -- "FALSE" --> C["Set normal button image\nreturn nullptr"]
    B -- "TRUE" --> D["m_genStarFlashTimeAccumulator\n+= TheFramePacer->getUpdateTime()"]
    D --> E{"accumulator\n>= 1.0s?"}
    E -- "YES" --> F["accumulator -= 1.0s\n(wrap modulo 1s)"]
    F --> E
    E -- "NO" --> G{"accumulator\n>= 0.5s?"}
    G -- "YES (second half)" --> H["Set highlight image\nreturn nullptr"]
    G -- "NO (first half)" --> I["Set normal image\nreturn nullptr"]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["getStarImage() called\n(each render frame)"] --> B{m_genStarFlash?}
    B -- "FALSE" --> C["Set normal button image\nreturn nullptr"]
    B -- "TRUE" --> D["m_genStarFlashTimeAccumulator\n+= TheFramePacer->getUpdateTime()"]
    D --> E{"accumulator\n>= 1.0s?"}
    E -- "YES" --> F["accumulator -= 1.0s\n(wrap modulo 1s)"]
    F --> E
    E -- "NO" --> G{"accumulator\n>= 0.5s?"}
    G -- "YES (second half)" --> H["Set highlight image\nreturn nullptr"]
    G -- "NO (first half)" --> I["Set normal image\nreturn nullptr"]

Loading

_{Reviews (5): Last reviewed commit: "refactor(controlbar): rename star blink ..." | Re-trigger Greptile}

pausing