Improve documentation and clarify edge cases for aliquot sum algorithm#90
Merged
dlesnoff merged 5 commits intoTheAlgorithms:mainfrom Jan 24, 2026
Merged
Improve documentation and clarify edge cases for aliquot sum algorithm#90dlesnoff merged 5 commits intoTheAlgorithms:mainfrom
dlesnoff merged 5 commits intoTheAlgorithms:mainfrom
Conversation
Contributor
Author
|
Thanks for reviewing. Happy to make any changes if needed. |
dlesnoff
reviewed
Jan 23, 2026
dlesnoff
reviewed
Jan 23, 2026
dlesnoff
reviewed
Jan 23, 2026
dlesnoff
requested changes
Jan 23, 2026
Collaborator
dlesnoff
left a comment
dlesnoff
left a comment
There was a problem hiding this comment.
Thanks for putting the examples at the beginning of the file.
A few changes might make it even better..
Co-authored-by: Dimitri Lesnoff <54949944+dlesnoff@users.noreply.github.com>
Co-authored-by: Dimitri Lesnoff <54949944+dlesnoff@users.noreply.github.com>
Co-authored-by: Dimitri Lesnoff <54949944+dlesnoff@users.noreply.github.com>
dlesnoff
reviewed
Jan 23, 2026
dlesnoff
requested changes
Jan 23, 2026
Collaborator
dlesnoff
left a comment
dlesnoff
left a comment
There was a problem hiding this comment.
A small typo and it should be all good
Co-authored-by: Dimitri Lesnoff <54949944+dlesnoff@users.noreply.github.com>
dlesnoff
approved these changes
Jan 24, 2026
Collaborator
dlesnoff
left a comment
dlesnoff
left a comment
There was a problem hiding this comment.
Thanks for the documentation improvement!
Contributor
Author
|
Thanks for the review and merge. Glad the documentation update was useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the documentation of the aliquot sum implementation by clarifying definitions, input constraints, edge cases, and time complexity.
Motivation
Clear documentation helps readers understand the mathematical meaning and expected behavior of the algorithm without changing its implementation.
Checklist