fix: fallback to single-thread init when mt startup fails#1946
Open
maxkrut wants to merge 1 commit intoThatOpen:mainfrom
Open
fix: fallback to single-thread init when mt startup fails#1946maxkrut wants to merge 1 commit intoThatOpen:mainfrom
maxkrut wants to merge 1 commit intoThatOpen:mainfrom
Conversation
Add a timeout-protected MT initialization path and automatically retry with the single-thread wasm module when MT startup fails, preventing Init() from hanging indefinitely under pthread worker failures.
Author
|
Repro context for this fix:
Current behavior before this patch:
Expected behavior:
This PR adds a timeout-guarded MT init path and retries with ST automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Init()callsTest plan
npm run build-ts-api && npm run build-web-ifc-api-nodenpm test(fails in this local environment because./web-ifc-nodewasm runtime artifacts are not present)