[good first issue] fix(scene): adapt memory prompts to dialogue language#147
Open
sirenexcelsior wants to merge 1 commit into
Open
[good first issue] fix(scene): adapt memory prompts to dialogue language#147sirenexcelsior wants to merge 1 commit into
sirenexcelsior wants to merge 1 commit into
Conversation
Collaborator
|
Thank you for participating in our good first issue event, we will complete the review internally as soon as possible! |
Signed-off-by: Siren.W <sirenexcelsior@gmail.com>
3965c99 to
049357b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #122.
This PR removes hardcoded Chinese output headings from the scene/persona prompt templates and replaces them with an explicit dialogue-language contract.
What changed
persona.mdfor non-Chinese scene content.Root cause
The scene extraction template included hardcoded Chinese Markdown section headings. LLMs may copy those headings into persisted scene/persona memory files even when the dialogue language is English, German, Russian, French, or another non-Chinese language.
Validation
npm run buildpassed.deepseek-v4-flashpassed for English, German, Russian, and French scene extraction prompts: no Chinese heading leakage and no unintended English fallback headings for non-English cases.