Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
We are doing this to make it easier for us to code auto since I am encountering some issues with existing auto pathplanner so I decided to switch into open source version and it worked fine. I think our original pathplanner works perfectly fine, but I cannot grasp the complex logic of creating obstacles, creating paths through code, and pathplanner provides a library that has is more battle tested and used in different teams. They also have a little fail safe mechaism that stops pathplanning when they are stuck, so much quality features and more documented code. I don't think adapting this will hinder the learning process, I am still using their pathplanning api and its easy to extend as I am still coding the keypoints in the map, but I can now edit with navgrid.json and if I don't want to code the keypoints, I can use gui to sacrfice some extensibility.
Whats changing?
Questions/notes for reviewers
How this was tested