PrezelList 구현

[HamBeomJoon]

📌 작업 내용

PrezelList 컴포넌트 구현

🧩 관련 이슈

• close PrezelList 구현 #71

📸 스크린샷

📢 논의하고 싶은 내용

• trailingContents: ImmutableList<@composable () -> Unit> = persistentListOf(), 으로받았는데 그냥 Composable로 받으면될까요?
• size: PrezelListSize = PrezelListSize.REGULAR, 기본값으로 Regular를 했는데, 기본값 없애고 필수 파라미터로 변경하는게 좋을까요?

Summary by CodeRabbit

릴리스 노트

• 새로운 기능
  • 디자인 시스템에 새로운 수평 목록 컴포넌트 추가
  • 작음/일반 두 가지 사이즈 변형 지원
  • 선행 및 후행 콘텐츠 커스터마이징 가능
  • 중첩 레이아웃 옵션 포함

[coderabbitai]

Walkthrough

세 개의 새로운 파일을 추가하여 PrezelList 컴포넌트를 구현합니다. PrezelList.kt에서는 제목, 선택적 리딩 콘텐츠, 트레일링 콘텐츠를 포함하는 가로 방향 목록 행을 렌더링하는 컴포저블을 정의합니다. PrezelListStyle.kt에서는 SMALL과 REGULAR 두 가지 크기 변형을 지정하는 PrezelListSize 열거형과 아이콘, 패딩, 텍스트 스타일, 간격을 관리하는 내부 컴포저블들을 제공합니다. PrezelListPreview.kt에서는 다양한 구성(중첩, 리딩 표시, 트레일링 표시)을 보여주는 미리보기 컴포저블들을 추가합니다.

Possibly related PRs

• PrezelButton 구현 #25: PrezelList 컴포넌트에서 직접 사용되는 IconSource 및 DrawableIcon 추상화를 도입합니다.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	PR 제목 'PrezelList 구현'은 추가된 주요 변경사항인 PrezelList 컴포넌트 구현을 명확하게 요약하고 있습니다.
Description check	✅ Passed	PR 설명은 리포지토리의 필수 템플릿 구조를 완전히 따르고 있으며, 작업 내용, 관련 이슈, 스크린샷, 논의사항을 모두 포함하고 있습니다.
Linked Issues check	✅ Passed	PR의 코드 변경사항(PrezelListSize 열거형, PrezelList 컴포넌트, 스타일 유틸리티, 프리뷰)이 이슈 #71의 PrezelList 컴포넌트 구현 요구사항을 모두 충족합니다.
Out of Scope Changes check	✅ Passed	모든 코드 변경사항이 이슈 #71의 PrezelList 컴포넌트 구현 요구사항 범위 내에 있습니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelList.kt (1)

30-35: showFirstTrailingContent 네이밍과 실제 동작 의미를 맞춰주세요.

현재는 showFirstTrailingContent = false일 때만 첫 아이템 1개로 제한되고, true면 전체가 노출됩니다. 호출자 입장에서 의미를 반대로 해석하기 쉬운 API입니다. 동작을 뒤집거나(이름 유지), 파라미터명을 showAllTrailingContents/limitToFirstTrailingContent처럼 명확하게 바꾸는 쪽이 안전합니다.

예시: 의미를 드러내는 파라미터명으로 변경

-    showFirstTrailingContent: Boolean = true,
+    showAllTrailingContents: Boolean = true,
...
-    val visibleTrailingContents =
-        if (!showFirstTrailingContent) trailingContents.take(1) else trailingContents
+    val visibleTrailingContents =
+        if (showAllTrailingContents) trailingContents else trailingContents.take(1)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelList.kt`
around lines 30 - 35, The parameter showFirstTrailingContent is misnamed vs its
behavior; rename it to showAllTrailingContents (or an equivalent clear name) and
update the logic in visibleTrailingContents so that when showAllTrailingContents
is true you return trailingContents, otherwise limit to
trailingContents.take(1); also update the parameter default and any call sites
that use showFirstTrailingContent to the new name to keep the API meaning clear.

Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelListPreview.kt (1)

57-67: prezelListTrailingIcons의 @Composable은 제거해도 됩니다.

이 함수는 컴포지션 상태를 읽지 않고 정적 리스트를 만드는 역할이라 일반 함수로 두는 편이 더 단순합니다.

정리 예시

-@Composable
 private fun prezelListTrailingIcons(size: PrezelListSize): ImmutableList<@Composable () -> Unit> =
     List(2) {
         `@Composable` {
             PrezelListIcon(
                 icon = IconSource(resId = PrezelIcons.Blank),
                 size = size,
             )
         }
     }.toPersistentList()

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelListPreview.kt`
around lines 57 - 67, Remove the unnecessary `@Composable` annotation from the
prezelListTrailingIcons function signature so it becomes a regular function that
returns ImmutableList<@Composable () -> Unit>; keep the inner lambdas (the
`@Composable` { PrezelListIcon(...) }) as-is so callers still get composable
trailing icon lambdas. Update the declaration of prezelListTrailingIcons (and
any related imports if needed) to be a plain function using PrezelListSize and
returning the same List(...).toPersistentList() result.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelList.kt`:
- Around line 55-66: The Spacer with
Modifier.width(prezelListTextTrailingSpacing(size = size)) is always rendered
causing unwanted space even when showTrailingContent is false; move the Spacer
inside the same conditional as the trailing Row so both the trailing spacing and
the Row (which renders visibleTrailingContents) are only rendered when
showTrailingContent is true—i.e., wrap the Spacer and the Row together under the
showTrailingContent check (references: Spacer, prezelListTextTrailingSpacing,
showTrailingContent, Row, visibleTrailingContents).

---

Nitpick comments:
In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelList.kt`:
- Around line 30-35: The parameter showFirstTrailingContent is misnamed vs its
behavior; rename it to showAllTrailingContents (or an equivalent clear name) and
update the logic in visibleTrailingContents so that when showAllTrailingContents
is true you return trailingContents, otherwise limit to
trailingContents.take(1); also update the parameter default and any call sites
that use showFirstTrailingContent to the new name to keep the API meaning clear.

In
`@Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelListPreview.kt`:
- Around line 57-67: Remove the unnecessary `@Composable` annotation from the
prezelListTrailingIcons function signature so it becomes a regular function that
returns ImmutableList<@Composable () -> Unit>; keep the inner lambdas (the
`@Composable` { PrezelListIcon(...) }) as-is so callers still get composable
trailing icon lambdas. Update the declaration of prezelListTrailingIcons (and
any related imports if needed) to be a plain function using PrezelListSize and
returning the same List(...).toPersistentList() result.

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5423a9e and ee3fe36.

📒 Files selected for processing (3)

• Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelList.kt
• Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelListPreview.kt
• Prezel/core/designsystem/src/main/java/com/team/prezel/core/designsystem/component/list/PrezelListStyle.kt