Skip to content

feat: Syntax Highlighting for Multiline Editor#1919

Open
camielvs wants to merge 1 commit intomasterfrom
03-09-feat_syntax_highlighting_for_multiline_editor
Open

feat: Syntax Highlighting for Multiline Editor#1919
camielvs wants to merge 1 commit intomasterfrom
03-09-feat_syntax_highlighting_for_multiline_editor

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Mar 9, 2026

Description

Adds the option for syntax highlighting to the multiline texteditor via the new highlightSyntax prop.

When true it will render a select box for the user to choose a syntax language for highlighting purposes.

If the user selects plaintext the current vanilla TextArea component will render. If the user selects one of the provided code languages the Monaco Editor will render inside the dialog with syntax highlighting appropriate for that language.

This feature is currently implemented in all instances of the MultilineTextInputDialog though it is debateable if it has use for the Annotation Editor.

Related Issue and Pull requests

Progresses #1891
Progresses https://github.com/Shopify/oasis-frontend/issues/391

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before

image.png

After

image.png

image.png

Demo:

syntax-highlighting-opt1.mov (uploaded via Graphite)

Test Instructions

Confirm that the multiline text editor now renders a select box and that changing the language renders the code viewer and appropriately highlights syntax.

Additional Comments

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-09-feat_syntax_highlighting_for_multiline_editor/a9aafc1`

Copy link
Collaborator Author

camielvs commented Mar 9, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 03-09-feat_syntax_highlighting_for_multiline_editor branch from 07521b3 to 9bc9b08 Compare March 10, 2026 20:01
@camielvs camielvs force-pushed the 03-09-feat_syntax_highlighting_for_multiline_editor branch from 9bc9b08 to 8ffdfa5 Compare March 10, 2026 20:19
@camielvs camielvs marked this pull request as ready for review March 10, 2026 20:50
@camielvs camielvs requested a review from a team as a code owner March 10, 2026 20:50
@camielvs camielvs requested a review from Mbeaulne March 11, 2026 01:03
@camielvs camielvs force-pushed the 03-09-feat_syntax_highlighting_for_multiline_editor branch from 8ffdfa5 to a9aafc1 Compare March 11, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants