feat: Syntax Highlighting for Multiline Editor#1919
Open
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
07521b3 to
9bc9b08
Compare
3 tasks
9bc9b08 to
8ffdfa5
Compare
morgan-wowk
approved these changes
Mar 10, 2026
Mbeaulne
requested changes
Mar 10, 2026
8ffdfa5 to
a9aafc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds the option for syntax highlighting to the multiline texteditor via the new
highlightSyntaxprop.When
trueit will render a select box for the user to choose a syntax language for highlighting purposes.If the user selects
plaintextthe current vanillaTextAreacomponent will render. If the user selects one of the provided code languages the Monaco Editor will render inside the dialog with syntax highlighting appropriate for that language.This feature is currently implemented in all instances of the
MultilineTextInputDialogthough it is debateable if it has use for the Annotation Editor.Related Issue and Pull requests
Progresses #1891
Progresses https://github.com/Shopify/oasis-frontend/issues/391
Type of Change
Checklist
Screenshots (if applicable)
Before
After
Demo:
syntax-highlighting-opt1.mov (uploaded via Graphite)
Test Instructions
Confirm that the multiline text editor now renders a select box and that changing the language renders the code viewer and appropriately highlights syntax.
Additional Comments