Merged
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
03-06-feat_link_to_node_on_canvas
branch
3 times, most recently
from
1289edc to
6c1e47d
Compare
3 tasks
camielvs
force-pushed
the
03-06-feat_link_to_node_on_canvas
branch
from
6c1e47d to
571a7c4
Compare
camielvs
commented
Mar 9, 2026
Comment on lines
891
to
+901
| useEffect(() => { | ||
| reactFlowInstance?.fitView({ | ||
| maxZoom: 1, | ||
| duration: 300, | ||
| }); | ||
| }, [currentSubgraphPath, reactFlowInstance]); | ||
| if (!reactFlowInstance) return; | ||
|
|
||
| if (!initialFitDone.current) { | ||
| initialFitDone.current = true; | ||
|
|
||
| if (!fitViewOnInit) return; | ||
| } | ||
|
|
||
| reactFlowInstance.fitView({ maxZoom: 1, duration: 300 }); | ||
| }, [currentSubgraphPath, reactFlowInstance, fitViewOnInit]); |
Collaborator
Author
There was a problem hiding this comment.
If we don't skip the canvas-level view-fitting operation it overrides the node-level operation
morgan-wowk
approved these changes
Mar 10, 2026
Collaborator
Author
camielvs
force-pushed
the
03-06-feat_link_to_node_on_canvas
branch
from
571a7c4 to
0c61088
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a button to Task, IO & Flex Nodes in Run View to copy a shareable link to clipboard. This link, when loaded, will load the pipeline and zoom the view into the chosen node. The node will be automatically selected & highlighted. The highlight will clear when the user clicks anywhere. The url will also clean itself up. I have done this because it felt annoying to have the task permanently highlighted, and it made the url logic complex if I then wanted to highlight a different node.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/498
Type of Change
Checklist
Screenshots (if applicable)
zoom-to-node.mov (uploaded via Graphite)
Test Instructions
Additional Comments