fix: lit produces dist-js which needs to be a prod build output by TkDodo · Pull Request #10995 · TanStack/query

TkDodo · 2026-06-27T18:15:04Z

Summary by CodeRabbit

Chores
- Updated build artifact tracking so the build process now recognizes additional output folders, improving consistency for generated files and cached build results.

coderabbitai · 2026-06-27T18:15:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 98036512-dc25-484a-91ea-d2b17229bef2

📥 Commits

Reviewing files that changed from the base of the PR and between b03390b and c592e90.

📒 Files selected for processing (1)

nx.json

📝 Walkthrough

Walkthrough

The build target outputs array in nx.json is expanded from two entries ({projectRoot}/build, {projectRoot}/dist) to three, adding {projectRoot}/dist-cjs as a recognized Nx artifact output.

Nx Build Outputs

Layer / File(s)	Summary
Add dist-cjs output path `nx.json`	`{projectRoot}/dist-cjs` is added to the `build` target `outputs` array alongside the existing `build` and `dist` entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops and adds a path,
dist-cjs joins the aftermath.
Three outputs now where two once stood,
Nx caches all just as it should.
🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, so the required template sections are missing.	Add the Changes, Checklist, and Release Impact sections from the template, with brief details for each item.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is related to the build output change, though it mentions dist-js while the change adds dist-cjs output.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/fix/lit-nx-config

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-06-27T18:15:34Z

View your CI Pipeline Execution ↗ for commit c592e90

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	7m 14s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 54s	View ↗

☁️ Nx Cloud last updated this comment at 2026-06-27 18:23:40 UTC

github-actions · 2026-06-27T18:16:08Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-06-27T18:18:51Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10995

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10995

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@10995

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10995

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@10995

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@10995

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10995

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10995

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10995

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10995

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10995

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10995

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10995

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10995

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10995

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10995

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10995

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10995

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10995

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10995

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10995

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10995

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10995

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10995

commit: c592e90

github-actions · 2026-06-27T18:20:59Z

size-limit report 📦

Path	Size
react full	12.13 KB (0%)
react minimal	9.08 KB (0%)

fix: lit produces dist-js which needs to be a prod build output

c592e90

TkDodo requested a review from a team as a code owner June 27, 2026 18:15

schiller-manuel approved these changes Jun 27, 2026

View reviewed changes

TkDodo merged commit 9cb8eac into main Jun 27, 2026
9 checks passed

TkDodo deleted the feature/fix/lit-nx-config branch June 27, 2026 19:21

coderabbitai Bot mentioned this pull request Jun 28, 2026

fix(lit-query): migrate to standard tsup build so 'build' output is cached by nx and 'test:build' passes #10943

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: lit produces dist-js which needs to be a prod build output#10995

fix: lit produces dist-js which needs to be a prod build output#10995
TkDodo merged 1 commit into
mainfrom
feature/fix/lit-nx-config

TkDodo commented Jun 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 27, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jun 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 27, 2026

Uh oh!

pkg-pr-new Bot commented Jun 27, 2026

Uh oh!

github-actions Bot commented Jun 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

TkDodo commented Jun 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 27, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Jun 27, 2026

Uh oh!

github-actions Bot commented Jun 27, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TkDodo commented Jun 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 27, 2026 •

edited

Loading

nx-cloud Bot commented Jun 27, 2026 •

edited

Loading