Skip to content

chore: update Start discovery fixture dependencies - #303

Merged
tannerlinsley merged 1 commit into
mainfrom
chore/start-fixture-dependencies
Oct 1, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
chore/start-fixture-dependencies

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Update the Start discovery fixture to React Start 1.168.60 and React Router 1.170.41, the September 30 patch releases. The fixture stays private and its app source stays unchanged.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr (run pnpm build:all first).

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Validation: frozen install, pnpm build:all, pnpm test:pr, and the full pnpm test suite passed. The saved-transcript pnpm eval:intent-discovery suite has the same three failures on unchanged main and this branch. Those expectations still use an older generated guidance command. This dependency-only update does not change that command or those expectations.

Summary by CodeRabbit

  • Chores
    • Updated the React Router and React Start versions used in the intent discovery fixture.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ca1bc2fd-0871-4fb6-9cd1-d9e908c55952

📥 Commits

Reviewing files that changed from the base of the PR and between cf6f070 and d01cdef.

📒 Files selected for processing (1)
  • evals/intent-discovery/fixtures/start-basic/package.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The start-basic fixture updates its @tanstack/react-router and @tanstack/react-start dependency versions.

Changes

Fixture dependency updates

Layer / File(s) Summary
Update fixture package versions
evals/intent-discovery/fixtures/start-basic/package.json
Updates @tanstack/react-router from 1.170.16 to 1.170.41 and @tanstack/react-start from 1.168.26 to 1.168.60.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d01cd

The change updates dependency pins in a fixture that the inspected evaluation path does not install or run. No user-facing behavior or actionable workflow failure is established, so the PR is ready to merge with normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to d01cd

The change affects 1 system.

Changed systems: evals

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — evals (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in evals/intent-discovery/fixtures/start-basic/package.json: The fixture dependency versions change: @tanstack/react-router from 1.170.16 to 1.170.41, and @tanstack/react-start from 1.168.26 to 1.168.60.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency update to the Start discovery fixture and accurately reflects the main change.
Description check ✅ Passed The description includes all required sections, explains the dependency updates and motivation, records checklist items, identifies the change as non-release, and reports validation results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d01cdef

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 2s View ↗
nx run-many --targets=build ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-01 17:33:48 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@303

commit: d01cdef

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​tanstack/​react-router@​1.170.41931008798100
Updated@​tanstack/​react-start@​1.168.26 ⏵ 1.168.609910088 +598100

View full report

@tannerlinsley
tannerlinsley merged commit 2697183 into main Oct 1, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the chore/start-fixture-dependencies branch October 1, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant