Let TaloLeaderboardEntriesManager.get_entries() return Array[TaloLeaderboardEntry].#78
Closed
Daylily-Zeleen wants to merge 1 commit into
Closed
Conversation
…eaderboardEntry]`
tudddorrr
requested changes
Feb 25, 2025
| for idx in range(entry.position, _current_entries[internal_name].size()): | ||
| _current_entries[internal_name][idx].position = idx | ||
| for idx in range(entry.position, named_entries.size()): | ||
| named_entries[idx].position = idx |
Contributor
There was a problem hiding this comment.
right now this actually doesn't return any entries. you need to add _current_entries[internal_name] = named_entries to update _current_entries with the latest changes to named_entries.
Contributor
There was a problem hiding this comment.
@Daylily-Zeleen just wanted to check you saw this comment?
Contributor
|
Thanks for this, closing in favour of #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #70 .