Add ChannelPage and use it instead of returning a tuple like Array.#76
Merged
Merged
Conversation
Daylily-Zeleen
changed the title
ChannelPage and use it instead of return a tuple like Array.ChannelPage and use it instead of returning a tuple like Array.
Daylily-Zeleen
force-pushed
the
channel_page
branch
2 times, most recently
from
e92cfa5 to
82ea9f0
Compare
tudddorrr
reviewed
Feb 25, 2025
| var res = await Talo.channels.get_channels(0) | ||
| var channels = res[0] | ||
| assert(is_instance_valid(res)) | ||
| var channels = res.channels |
Contributor
There was a problem hiding this comment.
is there some GDScript limitation here where async code doesn't pass through the correct type? hovering over res I don't see that its a ChannelPage
Contributor
Author
There was a problem hiding this comment.
GDScript can infer the return value type of async method with await. The type of res just not be inferred here.
Use ":=" instead of "=" can solve it.
But this is a type safe issue, it can be handled with other untyped code in an independent pr.
tudddorrr
requested changes
Feb 25, 2025
Comment on lines
+150
to
+151
| self.channels = p_channels | ||
| self.count = p_count |
Contributor
There was a problem hiding this comment.
you'll need to update these variable names to remove the p_ prefix (to match the params)
Contributor
Author
There was a problem hiding this comment.
Already fix now.
Daylily-Zeleen
force-pushed
the
channel_page
branch
from
82ea9f0 to
8dee1f6
Compare
tudddorrr
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #70 .