Skip to content

Create settings.cfg when plugin enableing instead of first time of running game.#74

Closed
Daylily-Zeleen wants to merge 1 commit into
TaloDev:developfrom
Daylily-Zeleen:create_default_settings
Closed

Create settings.cfg when plugin enableing instead of first time of running game.#74
Daylily-Zeleen wants to merge 1 commit into
TaloDev:developfrom
Daylily-Zeleen:create_default_settings

Conversation

@Daylily-Zeleen
Copy link
Copy Markdown
Contributor

A part of #70 .

But I think we should add these settings to ProjectSettings.

@Daylily-Zeleen Daylily-Zeleen force-pushed the create_default_settings branch from ee70105 to 5eecbbc Compare February 26, 2025 02:16
@tudddorrr tudddorrr added the enhancement New feature or request label Feb 26, 2025
@tudddorrr
Copy link
Copy Markdown
Contributor

@Daylily-Zeleen I'm getting this error in a fresh project: res://addons/talo/talo_autoload.gd:8 - Invalid call. Nonexistent function 'create_default_settings' in base 'GDScript'.

@Daylily-Zeleen
Copy link
Copy Markdown
Contributor Author

@Daylily-Zeleen I'm getting this error in a fresh project: res://addons/talo/talo_autoload.gd:8 - Invalid call. Nonexistent function 'create_default_settings' in base 'GDScript'.

It can work on my decice( win11 with godot 4.3-stable), what about your environment?

@tudddorrr
Copy link
Copy Markdown
Contributor

@Daylily-Zeleen I'm getting this error in a fresh project: res://addons/talo/talo_autoload.gd:8 - Invalid call. Nonexistent function 'create_default_settings' in base 'GDScript'.

It can work on my decice( win11 with godot 4.3-stable), what about your environment?

I'm on macOS with 4.3

@Daylily-Zeleen Daylily-Zeleen force-pushed the create_default_settings branch from 5eecbbc to a00630f Compare February 27, 2025 08:37
@Daylily-Zeleen
Copy link
Copy Markdown
Contributor Author

I have not macos device and can't test it.
I add some debug info, please test it again, and enable the plugin again.

If every thing is fine, it should output some message like this:
image

@tudddorrr
Copy link
Copy Markdown
Contributor

I have not macos device and can't test it. I add some debug info, please test it again, and enable the plugin again.

If every thing is fine, it should output some message like this: image

Really strange - I get:

false
<null>
<null>

I'm not sure why there would be any differences here on an OS level

@Daylily-Zeleen Daylily-Zeleen force-pushed the create_default_settings branch from a00630f to 5f1865d Compare February 28, 2025 02:38
@Daylily-Zeleen
Copy link
Copy Markdown
Contributor Author

I add @tool to "talo_manager.gd", please try again.

@tudddorrr
Copy link
Copy Markdown
Contributor

I add @tool to "talo_manager.gd", please try again.

That doesn't work either. I wonder if it's possible that talo_manager isn't compiling because it references Talo but the plugin hasn't been enabled yet so that class is invalid. So when referring to talo_manager I get an error because it hasn't been compiled properly?

@Daylily-Zeleen
Copy link
Copy Markdown
Contributor Author

I add @tool to "talo_manager.gd", please try again.

That doesn't work either. I wonder if it's possible that talo_manager isn't compiling because it references Talo but the plugin hasn't been enabled yet so that class is invalid. So when referring to talo_manager I get an error because it hasn't been compiled properly?

No, load a script will compile it.

All right, I will supersede this pr by making another pr that adding settings to project settings.

@Daylily-Zeleen
Copy link
Copy Markdown
Contributor Author

Supersede by #87 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants